Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining Desktop VPN work #12175

Merged
merged 43 commits into from
Apr 13, 2022
Merged

Remaining Desktop VPN work #12175

merged 43 commits into from
Apr 13, 2022

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 8, 2022 •
edited
Loading

Fixes brave/brave-browser#15804
Fixes brave/brave-browser#21314
Fixes brave/brave-browser#18469
Fixes brave/brave-browser#21598
Fixes brave/brave-browser#22061
Fixes brave/brave-browser#22109

TODO list

RELATED (required before we enable VPN feature by default)

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#15804

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Feb 8, 2022
@simonhong simonhong force-pushed the bsc-vpn-remaining-work branch 4 times, most recently from 489d1a6 to 08e3f12 Compare February 11, 2022 10:33
@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from 08e3f12 to 8777523 Compare February 11, 2022 21:05
@bsclifton bsclifton marked this pull request as ready for review February 15, 2022 20:53
@github-actions github-actions bot added rebase and removed rebase labels Feb 15, 2022
@brave-builds brave-builds force-pushed the bsc-vpn-remaining-work branch from 8777523 to f2ddd57 Compare February 15, 2022 20:56
@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from f2ddd57 to 0754659 Compare February 15, 2022 23:51
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from a1f1027 to 29f78ff Compare February 22, 2022 20:19
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from 41e9111 to 26bf07f Compare February 24, 2022 06:43
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from 5084a39 to 54d5deb Compare March 2, 2022 06:54
@petemill petemill force-pushed the bsc-vpn-remaining-work branch from 54d5deb to 49194a1 Compare March 2, 2022 20:56
@bsclifton bsclifton requested a review from a team as a code owner March 9, 2022 17:43
@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch 3 times, most recently from 41816ff to 5ea2bba Compare March 9, 2022 23:00
@petemill petemill force-pushed the bsc-vpn-remaining-work branch from 5ea2bba to 28482c4 Compare March 9, 2022 23:10
@bsclifton bsclifton force-pushed the bsc-vpn-remaining-work branch from 28482c4 to 38f913a Compare March 10, 2022 05:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

bsclifton and others added 15 commits April 12, 2022 08:39
@bsclifton @simonhong
Localize most of the contact support form
2c95a52
@bsclifton @simonhong
Add contact support form to error state
050b561
@simonhong
Added not allowed state to connection state
1e52ba3 
With this new connection state, service can notify with exact state info
when connection is not allowed by user or by system.
@simonhong
Added missing failure state notifying on macOS
1ed6a4b 
Fixes brave/brave-browser#22061
@bsclifton @simonhong
Sanitized all json data we receive back from API.
0e121b2 
Also, removed sensitive data logging
@simonhong
Added method for resetting connection state
4bc75c3 
We need to reset when we can move panel UI state from error page to
home page.
@nullhook @simonhong
Added connect not allowed note on the main panel
0935c94 
Fixes brave/brave-browser#22109
@simonhong
Fixed android gn_check failure
ec29281 
It seems gn_check can't handle #if BUILDFLAG(IS_ANDROID).
Although deps that added by this commit are not used on Android,
added to avoid gn_check failure.
@simonhong
Deleted country flags code leftovers
a20fd6a 
We will add country flags support in a separated PR.
@simonhong
Moved brave_vpn/mojom target to its own directory
484e6b4 
To avoid including brave_vpn target on linux mojom target is moved to
separated directory because storybook needs mojom_js for its building.
@simonhong
Updated vpn service's network traffic annotation
8652c0f 
Added policy part.
@simonhong
Fixed cached selected/device data is not refreshed
acf4230 
Instead of storing selected/device data as a whole,
just stores its name. Then gives region data from region list.
@simonhong
Deleted GetStringFor() and use mojom enum direclty for logging
e913c1e
@simonhong
Moved BraveVpnService/Factory into brave_vpn ns
6647609
@simonhong
Separated some helper/parsers method to helper.h
89fb27c
@simonhong simonhong force-pushed the bsc-vpn-remaining-work branch from 5be5bde to 89fb27c Compare April 11, 2022 23:52
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong
Copy link
Member

PTAL again @diracdeltas :)

@diracdeltas diracdeltas requested review from diracdeltas and removed request for diracdeltas April 12, 2022 18:18
@diracdeltas
Copy link
Member

all my comments are resolved, defer to andrea above

@simonhong simonhong requested a review from thypon April 12, 2022 23:39
thypon
thypon approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@thypon thypon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@bsclifton bsclifton added this to the 1.39.x - Nightly milestone Apr 13, 2022
@bsclifton bsclifton merged commit 704b20f into master Apr 13, 2022
@bsclifton bsclifton deleted the bsc-vpn-remaining-work branch April 13, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong left review comments

@diracdeltas diracdeltas diracdeltas left review comments

@goodov goodov goodov approved these changes

@thypon thypon thypon approved these changes

Assignees

@petemill petemill

@bsclifton bsclifton

@simonhong simonhong

@nullhook nullhook

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.39.x - Release
8 participants
@bsclifton @brave-builds @simonhong @goodov @diracdeltas @thypon @petemill @nullhook